Fixing domain error#72
Merged
Merged
Conversation
Fixed domain error, fixed unit test. Unit test uses a pseudo-homogeneous initial cloud -- a mix of ammonia and air -- and recovers the ammonia concentration afterwards.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 96.28% 96.28%
=======================================
Files 46 46
Lines 2905 2907 +2
=======================================
+ Hits 2797 2799 +2
Misses 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed domain error, added a keyword argument for temperature correction (makes it easier to compare against workbook answers).
Fixed unit test to use a pseudo-homogeneous initial cloud -- a mix of ammonia and air -- when checking against the workbook example.